Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update I/O threads documentation #222

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

uriyage
Copy link
Contributor

@uriyage uriyage commented Jan 26, 2025

Update IO threads documentation.

#196

topics/benchmark.md Outdated Show resolved Hide resolved
topics/latency.md Outdated Show resolved Hide resolved
topics/latency.md Show resolved Hide resolved
uriyage and others added 4 commits February 5, 2025 13:05
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: uriyage <[email protected]>
Signed-off-by: Uri Yagelnik <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: uriyage <[email protected]>
Signed-off-by: Uri Yagelnik <[email protected]>
Signed-off-by: Uri Yagelnik <[email protected]>
@uriyage uriyage force-pushed the update_io_threads_documentation branch from 7c0dc4a to d3024f9 Compare February 5, 2025 13:05
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranshid Was there anything else you identified that needed to get fixed?


### Limitations

I/O threading is currently not supported with TLS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that this is removed. It could be worth mentioning that it IS supported since 8.0 too, since users may remember that it wasn't supported in the past.

In another PR we can add some dedicated page for IO threading?

Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Should we add a dedicated page about I/O threading next?

@zuiderkwast
Copy link
Contributor

In the issue, I also mentioned these:

faq.md:

As of version 4.0, Valkey has started implementing threaded actions. For now this is limited to deleting objects in the background and blocking commands implemented via Valkey modules. For subsequent releases, the plan is to make Valkey more and more threaded.

latency-monitor.md:

Finally, Valkey is single threaded. This is usually an advantage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants